Conversation
mbore
force-pushed
the
improve-errors-in-autowire
branch
from
344c38f to
16fa26b
Compare
adamw
reviewed
Feb 14, 2022
| "constructInputProvider" -> List("Failed to create an instance of [B].", "Cannot construct instance of [String] on path [constructor B].a -> [constructor A].s"),//TODO we should add a warning in this case. | ||
| "missingConstructorDependencies" -> List("Failed to create an instance of [C].", "Cannot construct instance of [Int] on path [constructor C].b -> [constructor B].i"), | ||
| "missingApplyDependencies" -> List("Failed to create an instance of [", "C].", "Cannot construct instance of [Int] on path [constructor C].b -> [method apply].i"), | ||
| "missingFactoryMethodDependencies" -> List("Failed to create an instance of [C].", "Cannot construct instance of [Int] on path [constructor C].b -> [method makeB].i"), |
Member
There was a problem hiding this comment.
I think I'd adjust the error message. The problem that we are signalling is that there's a missing dependency - which causes creation of e.g. B impossible. So the error message should be sth like:
Missing dependency of type [Int]. Path: [constructor C].b -> [method makeB].i
Member
|
Except for the message I don't have anything to add, looks good :) |
adamw
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.